Update string key in data_grid_paginator.latte #1141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radimvaculik
requested changes
Aug 19, 2024
|
This PR fixed both strings and you closed it as BC break, perhaps you should intergrate that one: #1142 |
|
why do we want this? Changing translation keys will screw up many working projects and doesn't really add some big benefit... I don't see a point in forcing this,... Nice to make it consistent, but cost is to high. All projects that just upgrade will get those translations changed... It's a BC that IMHO does not make much sense to introduce. |
|
Unless you decide to revert what you’ve changed already, you should finish the job. https://github.com/search?q=repo%3Acontributte%2Fdatagrid%20contributte_datagrid.&type=code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.